Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix merge conflict #2

Conversation

intcreator
Copy link

correct branch this time

renovate bot and others added 30 commits March 9, 2024 19:30
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
## [3.1.7](v3.1.6...v3.1.7) (2024-04-08)

### 🛠 Builds

* **deps:** update dependency [@types](https://github.com/types)/luxon to ~3.4.0 ([#831](#831)) ([7c31bae](7c31bae))

### ⚙️ Continuous Integrations

* **action:** prevent duplicate checks on Renovate PRs ([#784](#784)) ([6b56a36](6b56a36))
* **action:** update actions/setup-node digest to 60edb5d ([#821](#821)) ([f05b75e](f05b75e))
* **action:** update actions/upload-artifact action to v4 ([#856](#856)) ([46d6660](46d6660))
* **action:** update amannn/action-semantic-pull-request digest to e9fabac ([#849](#849)) ([d96457c](d96457c))
* **action:** update github/codeql-action action to v2.22.6 ([#783](#783)) [skip ci] ([687fd43](687fd43))
* **action:** update github/codeql-action action to v2.22.7 ([#787](#787)) ([a0204d8](a0204d8))
* **action:** update github/codeql-action action to v2.22.8 ([#797](#797)) ([323f48c](323f48c))
* **action:** update github/codeql-action action to v3 ([#817](#817)) ([69d2695](69d2695))
* **action:** update insurgent-lab/is-in-pr-action action to v0.1.4 ([#790](#790)) ([8e85b13](8e85b13))
* **action:** update insurgent-lab/is-in-pr-action action to v0.1.5 ([#798](#798)) ([76751d2](76751d2))
* **action:** update insurgent-lab/is-in-pr-action action to v0.2.0 ([#853](#853)) ([cc3fcbd](cc3fcbd))
* **action:** update marocchino/sticky-pull-request-comment digest to 331f8f5 ([#850](#850)) ([a477f08](a477f08))
* **action:** update step-security/harden-runner action to v2.6.1 ([#788](#788)) [skip ci] ([2e5ca52](2e5ca52))
* **action:** update step-security/harden-runner action to v2.7.0 ([#846](#846)) ([f1a8486](f1a8486))
* fix renovate skipping checks ([#796](#796)) ([3b00555](3b00555))

### ♻️ Chores

* **deps:** lock file maintenance ([38979af](38979af))
* **deps:** lock file maintenance ([dc5b205](dc5b205))
* **deps:** lock file maintenance ([77ddb73](77ddb73))
* **deps:** lock file maintenance ([03eea6c](03eea6c))
* **deps:** lock file maintenance ([94e8aac](94e8aac))
* **deps:** lock file maintenance ([142c2d1](142c2d1))
* **deps:** lock file maintenance ([c70bd32](c70bd32))
* **deps:** lock file maintenance ([e0931ca](e0931ca))
* **deps:** lock file maintenance ([effe686](effe686))
* **deps:** lock file maintenance ([#763](#763)) ([5d17388](5d17388))
* **deps:** lock file maintenance ([#771](#771)) ([cf3d5e8](cf3d5e8))
* **deps:** lock file maintenance ([#781](#781)) ([6a00c1e](6a00c1e))
* **deps:** lock file maintenance ([#793](#793)) ([bcbc778](bcbc778))
* **deps:** lock file maintenance ([#804](#804)) ([2e72c8f](2e72c8f))
* **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v18.4.3 ([8c8acf7](8c8acf7))
* **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v18.4.4 ([2572023](2572023))
* **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v18.6.0 ([22e8a0f](22e8a0f))
* **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v18.6.1 ([e34c9d1](e34c9d1))
* **deps:** update dependency [@fast-check](https://github.com/fast-check)/jest to v1.8.0 ([689eea4](689eea4))
* **deps:** update dependency [@fast-check](https://github.com/fast-check)/jest to v1.8.1 ([a6a120c](a6a120c))
* **deps:** update dependency [@insurgent](https://github.com/insurgent)/conventional-changelog-preset to v9.0.1 ([39ae9c1](39ae9c1))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/github to v9.2.4 ([be59173](be59173))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/github to v9.2.6 ([4c994df](4c994df))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/npm to v11.0.1 ([#770](#770)) ([72f9dea](72f9dea))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/npm to v11.0.3 ([d62bc05](d62bc05))
* **deps:** update dependency [@types](https://github.com/types)/jest to v29.5.11 ([8fe499f](8fe499f))
* **deps:** update dependency [@types](https://github.com/types)/jest to v29.5.12 ([621f556](621f556))
* **deps:** update dependency [@types](https://github.com/types)/jest to v29.5.7 ([#765](#765)) [skip ci] ([3b9b43d](3b9b43d))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.10.0 ([3111ecd](3111ecd))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.10.4 ([b0853e7](b0853e7))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.10.5 ([35ee733](35ee733))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.10.7 ([603fdfa](603fdfa))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.0 ([a1a38fe](a1a38fe))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.13 ([c42b5e9](c42b5e9))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.17 ([f37f31c](f37f31c))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.19 ([c3bdd6d](c3bdd6d))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.24 ([fb4a087](fb4a087))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.25 ([4b22794](4b22794))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.26 ([166563d](166563d))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.27 ([8c14927](8c14927))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.28 ([bf7efeb](bf7efeb))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.30 ([ed26da9](ed26da9))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.5 ([8838ae5](8838ae5))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.11.8 ([006f6fc](006f6fc))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.12.2 ([f6bf108](f6bf108))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.12.3 ([30648f8](30648f8))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.12.4 ([7d5cf86](7d5cf86))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.8.10 ([#768](#768)) [skip ci] ([6a91b78](6a91b78))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.9.0 ([6d972d5](6d972d5))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.9.1 ([1817d85](1817d85))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.9.2 ([a9fb08b](a9fb08b))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.9.4 ([05124bb](05124bb))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.9.5 ([a32ba3d](a32ba3d))
* **deps:** update dependency [@types](https://github.com/types)/sinon to v17 ([#774](#774)) [skip ci] ([6ab97db](6ab97db))
* **deps:** update dependency [@typescript-eslint](https://github.com/typescript-eslint)/eslint-plugin to v6.11.0 ([d41dfa3](d41dfa3))
* **deps:** update dependency [@typescript-eslint](https://github.com/typescript-eslint)/eslint-plugin to v6.12.0 ([bd2e981](bd2e981))
* **deps:** update dependency [@typescript-eslint](https://github.com/typescript-eslint)/eslint-plugin to v6.13.1 ([#806](#806)) ([d696565](d696565))
* **deps:** update dependency [@typescript-eslint](https://github.com/typescript-eslint)/eslint-plugin to v6.13.2 ([d614393](d614393))
* **deps:** update dependency [@typescript-eslint](https://github.com/typescript-eslint)/eslint-plugin to v6.9.1 ([#766](#766)) [skip ci] ([4d2bfe6](4d2bfe6))
* **deps:** update dependency chai to v4.4.1 ([cd26e74](cd26e74))
* **deps:** update dependency eslint to v8.53.0 ([#773](#773)) [skip ci] ([8dea8d7](8dea8d7))
* **deps:** update dependency eslint to v8.54.0 ([ef4a99c](ef4a99c))
* **deps:** update dependency eslint to v8.55.0 ([f5578ac](f5578ac))
* **deps:** update dependency eslint-config-prettier to v9.1.0 ([ba1df8b](ba1df8b))
* **deps:** update dependency eslint-plugin-jest to v27.6.0 ([#762](#762)) ([615b06f](615b06f))
* **deps:** update dependency eslint-plugin-jest to v27.8.0 ([ca9c72d](ca9c72d))
* **deps:** update dependency prettier to v3.1.1 ([f31bd3b](f31bd3b))
* **deps:** update dependency semantic-release to v22.0.6 ([#767](#767)) [skip ci] ([230291a](230291a))
* **deps:** update dependency semantic-release to v22.0.9 ([ac87eba](ac87eba))
* **deps:** update dependency sinon to v17.0.1 ([#769](#769)) [skip ci] ([bf2bdfb](bf2bdfb))
* **deps:** update dependency ts-jest to v29.1.2 ([6f8af23](6f8af23))
* **deps:** update dependency typescript to v5.3.2 ([#802](#802)) ([0f541a4](0f541a4))
* **deps:** update dependency typescript to v5.3.3 ([4f470c6](4f470c6))
* **deps:** update dependency typescript to v5.4.2 ([98dfa32](98dfa32))
* **deps:** update dependency typescript to v5.4.3 ([412c453](412c453))
* **deps:** update dependency typescript to v5.4.4 ([6b172b1](6b172b1))
* **deps:** update linters ([2c2fe1b](2c2fe1b))
* **deps:** update linters ([66a470a](66a470a))
* **deps:** update linters ([3010a70](3010a70))
* **deps:** update linters ([f8609df](f8609df))
* **deps:** update linters ([8937be5](8937be5))
* **deps:** update linters ([834e0f4](834e0f4))
* **deps:** update linters ([fe0d705](fe0d705))
* **deps:** update linters ([767ad39](767ad39))
* **deps:** update semantic-release related packages ([38096a9](38096a9))
* **deps:** update semantic-release related packages ([a5cd89d](a5cd89d))
* **deps:** update semantic-release related packages ([#772](#772)) [skip ci] ([4a654a7](4a654a7))
* **deps:** update semantic-release related packages ([#777](#777)) ([898254c](898254c))
* **deps:** update tests ([eb417b6](eb417b6))
* **deps:** update tests ([0cdd4a3](0cdd4a3))
* **deps:** update tests ([#800](#800)) ([ea1a22b](ea1a22b))
* reduce renovate updates noise ([#750](#750)) ([661722f](661722f))
* reflect insurgentlab scope update in config files ([#785](#785)) ([edf67d0](edf67d0))
renovate bot and others added 27 commits November 9, 2024 22:20
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: intcreator <intcreator@gmail.com>
<!--- Provide a general summary of your changes in the Title above
(following the Conventional Commits standard) -->
<!-- More infos: https://www.conventionalcommits.org -->
<!-- Commit types:
https://github.com/insurgent-lab/conventional-changelog-preset#commit-types-->

## Description

<!--- Describe your changes in detail -->
Add support for Node v22. Keep support for v16 until we release a major
version.

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
We want to always support at least the latest 3 LTS Node versions

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
Added Node v22 to the test suite

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [ ] If my change introduces a breaking change, I have added a `!`
after the type/scope in the title (see the Conventional Commits
standard).
## [3.2.0](v3.1.9...v3.2.0) (2024-11-12)

### ✨ Features

* add support for Node v22 ([#914](#914)) ([9147b20](9147b20))

### ⚙️ Continuous Integrations

* **action:** update actions/checkout action to v4.2.2 ([#880](#880)) ([293f54a](293f54a))
* **action:** update actions/checkout digest to 11bd719 ([#879](#879)) ([0287c69](0287c69))
* **action:** update actions/setup-node digest to 39370e3 ([#889](#889)) ([0f7a3aa](0f7a3aa))
* **action:** update actions/upload-artifact action to v4.4.3 ([#878](#878)) ([226ad5b](226ad5b))
* **action:** update step-security/harden-runner action to v2.10.1 ([#882](#882)) ([b09438e](b09438e))

### ♻️ Chores

* **deps:** lock file maintenance ([ad613cb](ad613cb))
* **deps:** update dependency [@fast-check](https://github.com/fast-check)/jest to v2.0.3 ([2d00739](2d00739))
* **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/github to v11.0.1 ([a17bbdd](a17bbdd))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.17.6 ([4509c4d](4509c4d))
* **deps:** update dependency husky to v9 ([#844](#844)) ([9ea2216](9ea2216))
<!--- Provide a general summary of your changes in the Title above
(following the Conventional Commits standard) -->
<!-- More infos: https://www.conventionalcommits.org -->
<!-- Commit types:
https://github.com/insurgent-lab/conventional-changelog-preset#commit-types-->

## Description

<!--- Describe your changes in detail -->
Migrate .eslintrc to esling.config.mjs. Using .mjs so I can use `import`
(.ts configs are still experimental). Fixed a few lint issues that were
easy, changed one new lint rule to a warn since it wasn't caught before.

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->

Fixes #899 

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
Using the new flat config for Eslint is required for upgrading to 9.0

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
Ran `npm run lint` and VS Code Eslint plugin many times

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [ ] If my change introduces a breaking change, I have added a `!`
after the type/scope in the title (see the Conventional Commits
standard).
## [3.2.1](v3.2.0...v3.2.1) (2024-11-12)

### 🛠 Builds

* migrate eslint config to flat style ([#913](#913)) ([38c1044](38c1044)), closes [#899](#899)
<!--- Provide a general summary of your changes in the Title above
(following the Conventional Commits standard) -->
<!-- More infos: https://www.conventionalcommits.org -->
<!-- Commit types:
https://github.com/insurgent-lab/conventional-changelog-preset#commit-types-->

## Description

<!--- Describe your changes in detail -->
add a pre-commit hook to run eslint on .ts files and prettify on JSON,
MD, and YML files

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->
 fixes #907

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
a lot of times contributors make a PR just for it to fail because of
linting/prettification requirements and have to manually run the linters
locally and push a new commit with the fix. this change will
lint/prettify on commit automatically, removing friction to contribution

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [ ] If my change introduces a breaking change, I have added a `!`
after the type/scope in the title (see the Conventional Commits
standard).
This PR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
|
[github/codeql-action](https://redirect.github.com/github/codeql-action)
| action | patch | `v3.27.0` -> `v3.27.2` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/github/codeql-action/badge)](https://securityscorecards.dev/viewer/?uri=github.com/github/codeql-action)
|

---

### Release Notes

<details>
<summary>github/codeql-action (github/codeql-action)</summary>

###
[`v3.27.2`](https://redirect.github.com/github/codeql-action/releases/tag/v3.27.2)

[Compare
Source](https://redirect.github.com/github/codeql-action/compare/v3.27.1...v3.27.2)

##### CodeQL Action Changelog

See the [releases
page](https://redirect.github.com/github/codeql-action/releases) for the
relevant changes to the CodeQL CLI and language packs.

Note that the only difference between `v2` and `v3` of the CodeQL Action
is the node version they support, with `v3` running on node 20 while we
continue to release `v2` to support running on node 16. For example
`3.22.11` was the first `v3` release and is functionally identical to
`2.22.11`. This approach ensures an easy way to track exactly which
features are included in different versions, indicated by the minor and
patch version numbers.

##### 3.27.2 - 12 Nov 2024

- Fixed an issue where setting up the CodeQL tools would sometimes fail
with the message "Invalid value 'undefined' for header 'authorization'".
[#&#8203;2590](https://redirect.github.com/github/codeql-action/pull/2590)

See the full
[CHANGELOG.md](https://redirect.github.com/github/codeql-action/blob/v3.27.2/CHANGELOG.md)
for more information.

###
[`v3.27.1`](https://redirect.github.com/github/codeql-action/releases/tag/v3.27.1)

[Compare
Source](https://redirect.github.com/github/codeql-action/compare/v3.27.0...v3.27.1)

##### CodeQL Action Changelog

See the [releases
page](https://redirect.github.com/github/codeql-action/releases) for the
relevant changes to the CodeQL CLI and language packs.

Note that the only difference between `v2` and `v3` of the CodeQL Action
is the node version they support, with `v3` running on node 20 while we
continue to release `v2` to support running on node 16. For example
`3.22.11` was the first `v3` release and is functionally identical to
`2.22.11`. This approach ensures an easy way to track exactly which
features are included in different versions, indicated by the minor and
patch version numbers.

##### 3.27.1 - 08 Nov 2024

- The CodeQL Action now downloads bundles compressed using Zstandard on
GitHub Enterprise Server when using Linux or macOS runners. This speeds
up the installation of the CodeQL tools. This feature is already
available to GitHub.com users.
[#&#8203;2573](https://redirect.github.com/github/codeql-action/pull/2573)
- Update default CodeQL bundle version to 2.19.3.
[#&#8203;2576](https://redirect.github.com/github/codeql-action/pull/2576)

See the full
[CHANGELOG.md](https://redirect.github.com/github/codeql-action/blob/v3.27.1/CHANGELOG.md)
for more information.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am every weekday,every
weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/kelektiv/node-cron).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43LjEiLCJ1cGRhdGVkSW5WZXIiOiIzOS45LjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
|
[step-security/harden-runner](https://redirect.github.com/step-security/harden-runner)
| action | patch | `v2.10.1` -> `v2.10.2` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/step-security/harden-runner/badge)](https://securityscorecards.dev/viewer/?uri=github.com/step-security/harden-runner)
|

---

### Release Notes

<details>
<summary>step-security/harden-runner
(step-security/harden-runner)</summary>

###
[`v2.10.2`](https://redirect.github.com/step-security/harden-runner/compare/v2.10.1...v2.10.2)

[Compare
Source](https://redirect.github.com/step-security/harden-runner/compare/v2.10.1...v2.10.2)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am every weekday,every
weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/kelektiv/node-cron).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
|
[github/codeql-action](https://redirect.github.com/github/codeql-action)
| action | patch | `v3.27.2` -> `v3.27.5` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/github/codeql-action/badge)](https://securityscorecards.dev/viewer/?uri=github.com/github/codeql-action)
|

---

### Release Notes

<details>
<summary>github/codeql-action (github/codeql-action)</summary>

###
[`v3.27.5`](https://redirect.github.com/github/codeql-action/compare/v3.27.4...v3.27.5)

[Compare
Source](https://redirect.github.com/github/codeql-action/compare/v3.27.4...v3.27.5)

###
[`v3.27.4`](https://redirect.github.com/github/codeql-action/releases/tag/v3.27.4)

[Compare
Source](https://redirect.github.com/github/codeql-action/compare/v3.27.3...v3.27.4)

##### CodeQL Action Changelog

See the [releases
page](https://redirect.github.com/github/codeql-action/releases) for the
relevant changes to the CodeQL CLI and language packs.

Note that the only difference between `v2` and `v3` of the CodeQL Action
is the node version they support, with `v3` running on node 20 while we
continue to release `v2` to support running on node 16. For example
`3.22.11` was the first `v3` release and is functionally identical to
`2.22.11`. This approach ensures an easy way to track exactly which
features are included in different versions, indicated by the minor and
patch version numbers.

##### 3.27.4 - 14 Nov 2024

No user facing changes.

See the full
[CHANGELOG.md](https://redirect.github.com/github/codeql-action/blob/v3.27.4/CHANGELOG.md)
for more information.

###
[`v3.27.3`](https://redirect.github.com/github/codeql-action/releases/tag/v3.27.3)

[Compare
Source](https://redirect.github.com/github/codeql-action/compare/v3.27.2...v3.27.3)

##### CodeQL Action Changelog

See the [releases
page](https://redirect.github.com/github/codeql-action/releases) for the
relevant changes to the CodeQL CLI and language packs.

Note that the only difference between `v2` and `v3` of the CodeQL Action
is the node version they support, with `v3` running on node 20 while we
continue to release `v2` to support running on node 16. For example
`3.22.11` was the first `v3` release and is functionally identical to
`2.22.11`. This approach ensures an easy way to track exactly which
features are included in different versions, indicated by the minor and
patch version numbers.

##### 3.27.3 - 12 Nov 2024

No user facing changes.

See the full
[CHANGELOG.md](https://redirect.github.com/github/codeql-action/blob/v3.27.3/CHANGELOG.md)
for more information.

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am every weekday,every
weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/kelektiv/node-cron).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45LjUiLCJ1cGRhdGVkSW5WZXIiOiIzOS4xOS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
| [lint-staged](https://redirect.github.com/lint-staged/lint-staged) |
devDependencies | pin | [`^15.2.10` ->
`15.2.10`](https://renovatebot.com/diffs/npm/lint-staged/15.2.10/15.2.10)
| [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/lint-staged/lint-staged/badge)](https://securityscorecards.dev/viewer/?uri=github.com/lint-staged/lint-staged)
|

Add the preset `:preserveSemverRanges` to your config if you don't want
to pin your dependencies.

---

### Configuration

📅 **Schedule**: Branch creation - "before 5am every weekday,every
weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/kelektiv/node-cron).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45LjUiLCJ1cGRhdGVkSW5WZXIiOiIzOS45LjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
## Description
This PR improves async handling in the CronJob class and adds status
tracking functionality.

- Modified the `fireOnTick()` method to return a Promise for better
async callback handling
- Added an `isCallbackRunning` flag to track the running state of
CronJob instances
- Updated the test suite to use the new async behavior and track the
job's running state
- Added `waitForCompletion` functionality to the `job.stop()` method
- waits for running jobs to complete before executing the `onComplete`
callback

During test case writing, I encountered a type error with sinon.
To resolve this, added `sinon.restore()` to the `afterEach` block.

Reference:
https://stackoverflow.com/questions/73232999/sinon-cant-install-fake-timers-twice-on-the-same-global-object

<img width="811" alt="스크린샷 2024-09-03 오후 7 10 58"
src="https://github.com/user-attachments/assets/b87deee7-14b2-4407-8fea-a1cb469ef44b">

## Related Issue
Closes #713
Closes #556

## Motivation and Context
These changes allow the CronJob class to handle asynchronous callbacks
more effectively and provide a way to track the running state of jobs.

## How Has This Been Tested?
- Updated existing test suite to verify the new async behavior
- Adjusted test timeouts to use the `tickAsync` method
- Added new test cases to check for proper waiting of running callbacks
before stopping

## Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
- [x] My code follows the code style of this project.
- [x] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [ ] If my change introduces a breaking change, I have added a `!`
after the type/scope in the title (see the Conventional Commits
standard).

---------

Co-authored-by: Brandon der Blätter <intcreator@users.noreply.github.com>
## [3.3.0](v3.2.1...v3.3.0) (2024-12-10)

### ✨ Features

* support async handling and add CronJob status tracking ([#894](#894)) ([b58fb6b](b58fb6b)), closes [#713](#713) [#556](#556)

### ⚙️ Continuous Integrations

* **action:** update github/codeql-action action to v3.27.2 ([#912](#912)) ([d11ba30](d11ba30))
* **action:** update github/codeql-action action to v3.27.5 ([#917](#917)) ([2a4035e](2a4035e))
* **action:** update step-security/harden-runner action to v2.10.2 ([#920](#920)) ([26a8f9f](26a8f9f))
* add pre-commit hook to lint and prettify ([#911](#911)) ([e1140d1](e1140d1)), closes [#907](#907)

### ♻️ Chores

* **deps:** lock file maintenance ([94465ae](94465ae))
* **deps:** lock file maintenance ([23d67a4](23d67a4))
* **deps:** lock file maintenance ([135fdf7](135fdf7))
* **deps:** lock file maintenance ([edcff3b](edcff3b))
* **deps:** pin dependency lint-staged to 15.2.10 ([#916](#916)) ([5cf24da](5cf24da))
* **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v19.6.0 ([9d9ab94](9d9ab94))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.17.7 ([9181b6a](9181b6a))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.17.8 ([5899fc2](5899fc2))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.17.9 ([ca5065a](ca5065a))
* **deps:** update dependency husky to v9.1.7 ([a960a29](a960a29))
* **deps:** update dependency typescript to v5.7.2 ([3447ff5](3447ff5))
<!--- Provide a general summary of your changes in the Title above
(following the Conventional Commits standard) -->
<!-- More infos: https://www.conventionalcommits.org -->
<!-- Commit types:
https://github.com/insurgent-lab/conventional-changelog-preset#commit-types-->

## Description

<!--- Describe your changes in detail -->
fixes #923

## Related Issue

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->
#923

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
it makes the new feature actually work

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
modified test case added by #894

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [ ] If my change introduces a breaking change, I have added a `!`
after the type/scope in the title (see the Conventional Commits
standard).
## [3.3.1](v3.3.0...v3.3.1) (2024-12-12)

### 🐛 Bug Fixes

* correct waitForCompletion behavior ([#924](#924)) ([f6270f8](f6270f8)), closes [#923](#923) [#923](#923) [#894](#894)
@intcreator intcreator closed this Dec 16, 2024
@intcreator intcreator deleted the JosephVoid/feature/error-handling branch January 9, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants